Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweaks: Fix subtle following/mutuals indicators option #1654

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Tweaks: Fix subtle following/mutuals indicators option #1654

wants to merge 4 commits into from

Conversation

marcustyphoon
Copy link
Collaborator

@marcustyphoon marcustyphoon commented Nov 28, 2024 •
edited
Loading

Description

The "make following/mutuals indicators on notifications more subtle" tweak's purpose is to hide the text of the indicator in question, leaving only the smaller icon unless the user hovers over it. Staff removed the icons in question, breaking the feature; this adds the icons back and restores the functionality.

It also makes some tweaks required to work in the new activity notification types and to exclude the similar elements on the communities members page (as per the name of the feature; we could also make it work there but that seems like a separate thing).

Resolves #1649.

Improvement on #1568.

Testing steps

  • Confirm that the feature functions correctly on a new "replied to your post"/"replied to you in a post" notification from a mutual/followed user on both the activity page and in the activity modal.
  • Confirm that the feature functions correctly on the classic style of notification (most other notification types) from a mutual/followed user on both the activity page and in the activity modal.
  • Confirm that the mutual/following indicators on the communities members page are unaffected.

@marcustyphoon marcustyphoon self-assigned this Jan 4, 2025
@marcustyphoon marcustyphoon mentioned this pull request Jan 7, 2025
Closed
@marcustyphoon
Copy link
Collaborator Author

marcustyphoon commented Jan 10, 2025 •
edited
Loading

Well, this is a bit inconvenient. This stops happening if I set the display property on the random-div-containing-a-zero-width-space-for-wrapping-reasons to inline-block, I think, but t's not the most elegant thing to target with a CSS selector.

Edit: Ooh, it's even funnier without animations disabled :D Why is the svg span not being included in its parent's bounding box? I guess because it's itself inline-block?

Edit: Ah, it's because there's an anchor element covering this whole thing. I'm really not familiar with how pointer events work in those cases.

Edit 2: I think I see: the only reason that the blog name link is clickable/hoverable is because of a .activityContentWrapper a { position: relative; } rule, which causes the blog name link to create a new stacking context and I guess that punches through the overlaying anchor element. So making the mutual/following icon create a stacking context as well will allow it to punch through in the same way.

@marcustyphoon marcustyphoon added the help wanted Extra attention is needed label Jan 10, 2025
@marcustyphoon marcustyphoon removed their assignment Jan 10, 2025
@marcustyphoon marcustyphoon changed the title Tweaks: Add icons back to activity mutual indicators Tweaks: Fix subtle following/mutuals indicators option Jan 10, 2025
@marcustyphoon marcustyphoon removed the help wanted Extra attention is needed label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AprilSylph AprilSylph Awaiting requested review from AprilSylph

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tweaks: "Make following/mutuals indicators on notifications more subtle" option is broken
1 participant
@marcustyphoon